Skip to content

fix misc errors of launching swebench over slurm - #515

Merged
zihaok merged 2 commits into
mlcommons:mainfrom
zihaok:zihaok_fix_misc_pyxisruntime_issue
Sep 22, 2026
Merged

zihaok merged 2 commits into
mlcommons:mainfrom
zihaok:zihaok_fix_misc_pyxisruntime_issue

Conversation

@zihaok

@zihaok zihaok commented Sep 22, 2026 •

Copy link
Copy Markdown
Collaborator

What does this PR do?

Catch more pyxis runtime and slurm related swebench evaluation infra errors.
as a complement MR to this e4cd31d

Type of change

  • Bug fix
  • New feature
  • Documentation update
  • Refactor/cleanup

Related issues

Testing

  • Tests added/updated
  • All tests pass locally
  • Manual testing completed

Checklist

  • Code follows project style
  • Pre-commit hooks pass
  • Documentation updated (if needed)

@zihaok
zihaok requested a review from a team September 22, 2026 00:41
@github-actions

Copy link
Copy Markdown

MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅

@github-actions github-actions Bot added the size/normal PR Review Policy: <=500 non-test lines & <=20 files label Sep 22, 2026
@zihaok
zihaok requested a review from arekay-nv September 22, 2026 04:51
@codecov-commenter

codecov-commenter commented Sep 22, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (main@de4291f). Learn more about missing BASE report.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #515   +/-   ##
=======================================
  Coverage        ?   80.92%           
=======================================
  Files           ?      154           
  Lines           ?    21231           
  Branches        ?        0           
=======================================
  Hits            ?    17181           
  Misses          ?     4050           
  Partials        ?        0           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@arekay-nv arekay-nv left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@zihaok
zihaok requested a review from hvagadia September 22, 2026 19:07
@zihaok
zihaok merged commit cec2c28 into mlcommons:main Sep 22, 2026
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/normal PR Review Policy: <=500 non-test lines & <=20 files

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants