Skip to content

Allow tiny round-off exceedence of max_resolution in spatial check #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
leifdenby merged 3 commits into from
Mar 4, 2026
Merged

Allow tiny round-off exceedence of max_resolution in spatial check #30

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
04f31d5
Allow tiny round-off exceedence of max_resolution in spatial check
ladc Feb 22, 2026
a3d3856
Fix indentation in spatial.py
ladc Feb 22, 2026
35930f2
Update CHANGELOG.md with PR #30.
ladc Feb 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

### Fixed

- Make checks on max spatial resolution (1km) more lenient using math.isclose [\#30](https://github.com/mlcast-community/mlcast-dataset-validator/pull/30), @ladc
- Detect Zarr v3 format from store files (`zarr.json`) instead of relying on `getattr(ds, "zarr_format", 2)` which always defaulted to v2, causing v3 stores to incorrectly fail the consolidated metadata check [\#27](https://github.com/mlcast-community/mlcast-dataset-validator/pull/27), @franchg

## [v0.2.0](https://github.com/mlcast-community/mlcast-dataset-validator/releases/tag/v0.2.0)
Expand Down
10 changes: 8 additions & 2 deletions mlcast_dataset_validator/checks/coords/spatial.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
import math

import xarray as xr

from ...specs.reporting import ValidationReport, log_function_call
Expand Down Expand Up @@ -35,9 +37,13 @@ def check_spatial_requirements(
if len(x_vals) > 1 and len(y_vals) > 1:
x_res = abs(float(x_vals[1] - x_vals[0]))
y_res = abs(float(y_vals[1] - y_vals[0]))
max_resolution_m = max_resolution_km * 1000
if (
x_res <= max_resolution_km * 1000
and y_res <= max_resolution_km * 1000
x_res <= max_resolution_m
or math.isclose(x_res, max_resolution_m, rel_tol=1e-6)
) and (
y_res <= max_resolution_m
or math.isclose(y_res, max_resolution_m, rel_tol=1e-6)
):
report.add(
SECTION_ID,
Expand Down
Loading