Export Arg/Id Patterns #135
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kozross
requested changes
Oct 21, 2025
Comment on lines
+317
to
+330
| -- | This is the *safe* read-only pattern | ||
| pattern UnId :: Word64 -> Id | ||
| pattern UnId w <- Id w | ||
|
|
||
| -- | This is the *unsafe* pattern. | ||
| -- This should ONLY ever be used for tests and you should | ||
| -- NEVER use this to construct Ids manually. | ||
| pattern UnsafeId :: Word64 -> Id | ||
| pattern UnsafeId w = Id w | ||
|
|
||
| {-# COMPLETE UnId #-} | ||
|
|
||
| {-# COMPLETE UnsafeId #-} | ||
|
|
There was a problem hiding this comment.
You can do it like this. In Covenant.Internal.Term, define
newtype Id = UnsafeId Word64
...Export Id(..). Then, in Covenant.ASG, import Id (UnsafeId), then define
pattern UnId :: Word64 -> Id
pattern UnId w64 <- UnsafeId w64
{-# COMPLETE UnId #-}Then export Id (UnId) from Covenant.ASG.
Comment on lines
+356
to
+370
| -- | This is the 'safe' pattern which can be used anywhere to | ||
| -- deconstruct an arg | ||
| pattern UnArg :: DeBruijn -> Index "arg" -> Arg | ||
| pattern UnArg db i <- Arg db i _ | ||
|
|
||
| -- | This is the *unsafe* pattern, which should NEVER | ||
| -- be used to manually construct 'Arg's in an AST, and should | ||
| -- ONLY ever be used for tests. | ||
| pattern UnsafeArg :: DeBruijn -> Index "arg" -> ValT AbstractTy -> Arg | ||
| pattern UnsafeArg db i t = Arg db i t | ||
|
|
||
| {-# COMPLETE UnArg #-} | ||
|
|
||
| {-# COMPLETE UnsafeArg #-} | ||
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need these to write the code generator, unfortunately.
This is a bit of a mess (partly due to me needing to get this done ASAP today) in that we have
We could remove the non-pattern constructor exports from there... but it'd require a decent amount of fix-up that I do not have the time to do right now. If you suggest it I will be happy to do that later/tomorrow.