aggregate component #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Thanks @Hakimovich99,
This will only aggregate a single metric, right?
I would prefer to hardcode the metrics that we're using instead of making it dynamic and limited to a single metric.
No, it aggregates every metric. Here it's the context_relevancy and context_precision. It takes all metrics columns output from the previous component and gives the agg metric for each. |
Actually not interesting to have this argument. The user will already choose the metrics to compute in the "retriever_eval" component, no need to choose again which metrics to agg, we can just agg them all.
|
Ah yes, I see. Since you add the metrics as rows. Nice solution 👍 |
RobbeSneyders
deleted the
19-implement-component-to-aggregate-metrics-across-rows
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dask transform component to aggregate the evaluation results. Might have to be adapted to new dataset format.