Skip to content

fix(cpu): name the right routine in LUF and SVD error messages #4167

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zcbenz merged 1 commit into from
Aug 11, 2026
+4 −4
Merged

fix(cpu): name the right routine in LUF and SVD error messages #4167

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions mlx/backend/cpu/luf.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,8 +69,8 @@ void luf_impl(

if (info < 0) {
std::stringstream ss;
ss << "[LUF::eval_cpu] sgetrf_ failed with code " << info
<< " because argument had an illegal value";
ss << "[LUF::eval_cpu] LU factorization failed with error code "
<< info << " because argument had an illegal value";
throw std::runtime_error(ss.str());
}

Expand Down
4 changes: 2 additions & 2 deletions mlx/backend/cpu/svd.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@ struct SVDWork<

if (info != 0) {
std::stringstream ss;
ss << "svd_impl: sgesvdx_ failed with code " << info;
ss << "[SVD::eval_cpu] SVD failed with error code " << info;
throw std::runtime_error(ss.str());
}
}
Expand Down Expand Up @@ -181,7 +181,7 @@ struct SVDWork<std::complex<float>> {

if (info != 0) {
std::stringstream ss;
ss << "svd_impl: sgesvdx_ failed with code " << info;
ss << "[SVD::eval_cpu] SVD failed with error code " << info;
throw std::runtime_error(ss.str());
}
}
Expand Down