Skip to content

[Metal] Fix event leak - #3159

Merged
awni merged 1 commit into
mainfrom
fix_event_leak
Feb 24, 2026
Merged

[Metal] Fix event leak#3159
awni merged 1 commit into
mainfrom
fix_event_leak

Conversation

@awni

@awni awni commented Feb 23, 2026

Copy link
Copy Markdown
Member

There was an edge case where events can leak

Should close ml-explore/mlx-lm#887

@awni
awni requested a review from angeloskath February 23, 2026 20:43

@angeloskath angeloskath left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏

@awni
awni merged commit cb19826 into main Feb 24, 2026
31 of 32 checks passed
@awni
awni deleted the fix_event_leak branch February 24, 2026 03:50
@ivanfioravanti

Copy link
Copy Markdown
Contributor

Thanks 🙏 gonna try it right now!

jzdziarski pushed a commit to jzdziarski/mlx that referenced this pull request Jul 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

mlx_lm.evaluate - Failed to create Metal shared event.

3 participants