Fix python package install path in stubgen - #3009
Merged
Merged
Conversation
4 tasks
zcbenz
force-pushed
the
stubgen-python-path
branch
2 times, most recently
from
January 18, 2026 06:36
f2efbe3 to
c6b3cf7
Compare
zcbenz
force-pushed
the
stubgen-python-path
branch
from
January 18, 2026 23:15
c6b3cf7 to
9c4e24c
Compare
1 task
jzdziarski
pushed a commit
to jzdziarski/mlx
that referenced
this pull request
Jul 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We need to pass the path where the mlx package is installed to
stubgen, previously it was hard coded to~/mlx/pythonbut would fail for some cases like #3003 (comment). This PR fixes it by also searching the actual path of extension with the$<TARGET_FILE_DIR>expression.