replace MLX_IBV_COORDINATOR with MLX_JACCL_COORDINATOR - #2986
Merged
Conversation
1 task
Member
|
Sorry for not being able to get to this sooner but that was intentional as the devices are infiniband verbs devices. Moreover this PR breaks the launcher currently. I will make a PR to revert it but if people prefer this for some reason the I will adapt the PR to fix the launcher. |
Member
|
Well what I meant is breaks old launchers. Not the launcher on main. |
Contributor
Author
|
ah my bad! I think IBV devices makes sense in that case. |
angeloskath
added a commit
that referenced
this pull request
Jan 14, 2026
This reverts commit a819779.
jzdziarski
pushed a commit
to jzdziarski/mlx
that referenced
this pull request
Jul 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Expect MLX_JACCL_DEVICES instead of MLX_IBV_DEVICES in the JACCL distributed backend, consistent with the JACCL coordinator env var.
Please close if this was intended - but I couldn't find any discussion explicitly intending this behaviour.
Checklist
Put an
xin the boxes that apply.pre-commit run --all-filesto format my code / installed pre-commit prior to committing changes