Skip to content

Allow some non 2D inputs in qqmm - #2981

Merged
awni merged 1 commit into
mainfrom
qq_allow_some_non_2d_inputs
Jan 13, 2026
Merged

Allow some non 2D inputs in qqmm#2981
awni merged 1 commit into
mainfrom
qq_allow_some_non_2d_inputs

Conversation

@awni

@awni awni commented Jan 9, 2026

Copy link
Copy Markdown
Member

Allow x to be ND when the weights are 2D since it can be flattened or expanded to 2D.

@awni
awni requested a review from angeloskath January 9, 2026 20:21
@awni

awni commented Jan 9, 2026

Copy link
Copy Markdown
Member Author

CC @nastya236

@awni
awni force-pushed the qq_allow_some_non_2d_inputs branch from 6bff3dd to 7242970 Compare January 10, 2026 23:34
@awni
awni merged commit ac26a4c into main Jan 13, 2026
15 checks passed
@awni
awni deleted the qq_allow_some_non_2d_inputs branch January 13, 2026 23:48
jzdziarski pushed a commit to jzdziarski/mlx that referenced this pull request Jul 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants