Fix attention for large sizes#2903
Merged
Merged
Conversation
Member
Author
|
The change in the mma loader is just to speed it up so we don't lose perf using int64 stride for the mask. |
angeloskath
approved these changes
Dec 12, 2025
angeloskath
left a comment
angeloskath
left a comment
Member
There was a problem hiding this comment.
This looks great! I presume you ran some tests to check if there is any regression...
Member
Author
Yes I ran a benchmark for just SDPA and a model prefill benchmark and there is no change. In fact just changing to int64 without changing the loader was a consistent 1-2% slowdown on M2 Ultra (so not that bad). Changing the loader brought it back. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Close #2894