Do a PyPi release for cuda on arm#2866
Merged
Merged
Conversation
madrob
reviewed
Dec 3, 2025
zcbenz
reviewed
Dec 4, 2025
| with: | ||
| toolkit: 'cuda-12.9' | ||
| - name: Build Python package | ||
| uses: ./.github/actions/build-cuda-release |
Collaborator
There was a problem hiding this comment.
The arch is not passed.
with:
arch: ${{ matrix.arch }}
Member
Author
|
@madrob can you make an |
awni
force-pushed
the
arm_cuda_release
branch
2 times, most recently
from
422ff34 to
80762fd
Compare
awni
force-pushed
the
arm_cuda_release
branch
from
80762fd to
159bd0c
Compare
madrob
reviewed
Dec 4, 2025
Comment on lines
+133
to
+134
| arch: ['x86_64', 'aarch64'] | ||
| runs-on: ${{ matrix.arch == 'x86_64' && 'ubuntu-22-large' || 'ubuntu-22-large-arm' }} |
Contributor
There was a problem hiding this comment.
I would put the conditional logic in the matrix so it's easier to see:
Suggested change
| arch: ['x86_64', 'aarch64'] | |
| runs-on: ${{ matrix.arch == 'x86_64' && 'ubuntu-22-large' || 'ubuntu-22-large-arm' }} | |
| include: | |
| - host: ubuntu-22-large | |
| arch: x86_64 | |
| - host: ubuntu-22-large-arm | |
| arch: aarch64 | |
| runs-on: ${{ matrix.host }} |
zcbenz
reviewed
Dec 12, 2025
| using: "composite" | ||
| steps: | ||
| - name: Use ccache | ||
| if: ${{ runner.arch == 'x86_64' }} |
Collaborator
There was a problem hiding this comment.
@awni This disables ccache completely as x86_64 is not a valid value for runner.arch. Do you remember why it is disabled for arm build? Maybe we should add an input to just disable ccache for release builds?
Member
Author
There was a problem hiding this comment.
I think because it wasn't installed on the ubuntu-large-arm machine (the one we use for the release build).
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We already release the front-end package for Arm so this is a minimal change.