Skip to content

use thread local cpature mode#2850

Merged
awni merged 1 commit into
ml-explore:mainfrom
awni:local_capture_mode
Dec 2, 2025
Merged

use thread local cpature mode#2850
awni merged 1 commit into
ml-explore:mainfrom
awni:local_capture_mode

Conversation

@awni

@awni awni commented Dec 1, 2025

Copy link
Copy Markdown
Member

This avoids potential race with cudaFreeAsync which can result in the following crash:

  what():  cudaFreeAsync(buf->data, free_streams_[buf->device]) failed: operation not permitted when stream is capturing

@awni awni requested review from angeloskath and zcbenz December 1, 2025 23:14
angeloskath
angeloskath approved these changes Dec 2, 2025
View reviewed changes

@angeloskath angeloskath left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@awni awni merged commit 6c5785b into ml-explore:main Dec 2, 2025
12 checks passed
@awni awni deleted the local_capture_mode branch December 3, 2025 15:10
@BrewTestBot BrewTestBot mentioned this pull request Dec 18, 2025
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@angeloskath angeloskath angeloskath approved these changes
@zcbenz zcbenz Awaiting requested review from zcbenz

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@awni @angeloskath