Skip to content

Support more Numpy interfaces for masked_scatter#2832

Merged
angeloskath merged 1 commit into
ml-explore:mainfrom
CC-Yeh:fix_masked_scatter
Dec 2, 2025
Merged

Support more Numpy interfaces for masked_scatter#2832
angeloskath merged 1 commit into
ml-explore:mainfrom
CC-Yeh:fix_masked_scatter

Conversation

@CC-Yeh

@CC-Yeh CC-Yeh commented Nov 24, 2025

Copy link
Copy Markdown
Contributor

Proposed changes

close #2803

Checklist

Put an x in the boxes that apply.

  • I have read the CONTRIBUTING document
  • I have run pre-commit run --all-files to format my code / installed pre-commit prior to committing changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have updated the necessary documentation (if needed)

@angeloskath angeloskath left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me.

@angeloskath
angeloskath merged commit 8879ee0 into ml-explore:main Dec 2, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] Boolean masking doesn't work / match NumPy in some cases

2 participants