Skip to content

Fix mx.core.linspace type annotation#2820

Merged
awni merged 2 commits into
ml-explore:mainfrom
CC-Yeh:fix_linspace_type_annotation
Nov 24, 2025
Merged

Fix mx.core.linspace type annotation#2820
awni merged 2 commits into
ml-explore:mainfrom
CC-Yeh:fix_linspace_type_annotation

Conversation

@CC-Yeh

@CC-Yeh CC-Yeh commented Nov 22, 2025

Copy link
Copy Markdown
Contributor

Proposed changes

Close #2801

Checklist

Put an x in the boxes that apply.

  • I have read the CONTRIBUTING document
  • I have run pre-commit run --all-files to format my code / installed pre-commit prior to committing changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have updated the necessary documentation (if needed)

@CC-Yeh CC-Yeh changed the title fix mx.core.linspace type hint fix mx.core.linspace type annotation Nov 22, 2025
@CC-Yeh CC-Yeh changed the title fix mx.core.linspace type annotation Fix mx.core.linspace type annotation Nov 22, 2025
Comment thread python/src/ops.cpp Outdated
Co-authored-by: Awni Hannun <awni.hannun@gmail.com>
@CC-Yeh
CC-Yeh requested a review from awni November 22, 2025 21:09

@awni awni left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@CC-Yeh

CC-Yeh commented Nov 24, 2025

Copy link
Copy Markdown
Contributor Author

@awni

Looks like a sporadic failure, can you trigger the test again?

@awni
awni merged commit 1d4eacb into ml-explore:main Nov 24, 2025
18 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Partially unknown type for mlx.core.linspace with basedpyright.

2 participants