Force cudaGraphExec reinstantiation when clusters are used#2813
Merged
awni merged 2 commits intoNov 22, 2025
Conversation
Thread block cluster dimensions are not correctly updated by cudaGraphExecUpdate. Therefore, when clusters are used, we reinstantiate a cudaGraphExec rather than updating it.
awni
force-pushed
the
fix-cuda-graphs-update-clusters
branch
from
November 22, 2025 14:15
f54794d to
9886dbf
Compare
Member
|
Some benchmarks on B200 Inference with Pre: prompt_tps=59185.146 Pre: generation_tps=282.392 Pre: toks_per_sec: 97961.0518 |
Member
|
@andportnoy I changed this a bit more than I expected. Basically three changes:
|
awni
approved these changes
Nov 22, 2025
awni
left a comment
Member
There was a problem hiding this comment.
This resolves outstanding test failures! Thanks for the fix!!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Thread block cluster dimensions are not correctly updated by cudaGraphExecUpdate. Therefore, when clusters are used, we reinstantiate a cudaGraphExec rather than updating it.
Checklist
pre-commit run --all-filesto format my code / installed pre-commit prior to committing changesThe change fixes existing tests.