Avoid duplicate CI runs when starting a PR from upstream branch#2788
Merged
Conversation
Member
|
It's kind of odd how it shows the skipped tests in this case. Maybe it would be cleaner to just restrict push to main? |
Collaborator
Author
|
Yeah it does not look good, I have changed to test main branch only. |
Member
|
We could add a manual trigger like we have for the release workflow if you want to be able to run the CI on a ml-explore/mlx branch without making a PR. |
Member
|
Actually the way you have it also works well. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also makes the
check_lintruns faster.