feat: Add AdamW bias correction parameter.#400
Merged
davidkoski merged 1 commit intoMay 7, 2026
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
This PR adds a
biasCorrectionparameter to the SwiftAdamandAdamWoptimizers, matching the Python API and bias-corrected update rule used in MLX Python.The main motivation is consistency with the Python implementation and easier comparison against PyTorch and other common optimizer implementations. I don't know if this falls within the goals of the mlx-swift project but I definitely encountered a situation where this was preventing close comparison with an MPSGraph implementation which was itself written to behave like PyTorch.
Internally, this requires tracking the optimizer step so the bias-correction factors can be applied:
1 - beta1^t1 - beta2^tTo support that, this change replaces
TupleStatewith anAdamStateforAdam/AdamW, so the first moment, second moment, and step can be stored together.This PR also adds tests for the bias-corrected
AdamandAdamWpaths and updates the relevant optimizer documentation.Checklist
Put an
xin the boxes that apply.pre-commit run --all-filesto format my code / installed pre-commit prior to committing changes