Raise swift-syntax floor to 602.0.0 for prebuilt artifact resolution#340
Open
roryford wants to merge 1 commit into
Open
Raise swift-syntax floor to 602.0.0 for prebuilt artifact resolution#340roryford wants to merge 1 commit into
roryford wants to merge 1 commit into
Conversation
roryford
force-pushed
the
macro-free-huggingface-bridges
branch
from
be4bba7 to
7694c4d
Compare
roryford
changed the title
davidkoski
reviewed
Jun 11, 2026
Comment on lines
+43
to
+46
| // 602.0.0 floor: swift.org publishes signed prebuilt swift-syntax artifacts only for | ||
| // >= 602 tags on current toolchains; a 600.x/601.x resolution falls back to the full | ||
| // source compile of swift-syntax. | ||
| .package(url: "https://github.com/swiftlang/swift-syntax.git", "602.0.0" ..< "604.0.0"), |
davidkoski
reviewed
Jun 11, 2026
Comment on lines
+47
to
+48
| .package(url: "https://github.com/huggingface/swift-transformers", from: "1.3.0"), | ||
| .package(url: "https://github.com/huggingface/swift-huggingface", from: "0.9.0"), |
Collaborator
There was a problem hiding this comment.
We can't do this -- see #118 . The package resolution can't be turned off and name collisions are not allowed. There is some aliasing capability, but it was unable to solve it.
This is how we ended up with the macros. Or you can use the external (to mlx-explore) implementations.
swift.org's signed prebuilt swift-syntax artifacts are keyed per swift-syntax tag and exact toolchain, and 600.x/601.x artifacts are no longer published for current toolchains. A package graph that resolves below 602 silently falls back to compiling swift-syntax from source (~200 build tasks). Raising the floor keeps consumers on the prebuilt path. See ml-explore#339 for measurements. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
roryford
force-pushed
the
macro-free-huggingface-bridges
branch
from
7694c4d to
d6924bf
Compare
roryford
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Narrowed from the original proposal. This PR is now only the swift-syntax floor bump, flagged as useful
Why: swift.org publishes signed prebuilt swift-syntax artifacts only for >= 602 tags on current toolchains. A 600.x/601.x resolution silently falls back to compiling swift-syntax from source. Measured on Swift 6.3.2 / Xcode 26.5: forcing source compile adds ~46 Swift-compile tasks / ~29s of compile CPU per cold build (SwiftCompile 24.1s → 53.2s) that the prebuilt skips entirely.