Raise clear error when LoRA config uses 'alpha' instead of 'scale' - #1671
Open
arjunneema09 wants to merge 1 commit into
Open
Raise clear error when LoRA config uses 'alpha' instead of 'scale'#1671arjunneema09 wants to merge 1 commit into
arjunneema09 wants to merge 1 commit into
Conversation
mlx-lm's LoRA config format uses 'scale', but many LoRA tutorials and other frameworks use 'alpha' for a related concept, which previously caused a bare, unhelpful KeyError. This adds a message pointing users at the correct key. Fixes ml-explore#1670
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1670
What
Raises a clear
KeyErrormessage when a LoRA config usesalphainsteadof
scale, instead of the previous bareKeyError: 'scale'with no context.Why
mlx-lm's LoRA config format requires
scale, but many LoRA tutorials andother frameworks (e.g. PEFT) use
alphafor a related concept. This is aneasy mistake to make with a confusing failure mode.
Testing
Verified the syntax compiles cleanly. I wasn't able to run the full
reproduction locally due to an unrelated MLX/macOS 26.2 compatibility
issue on my machine (metallib load failure, independent of this change) —
happy to confirm behavior further if needed, or a maintainer can verify.