Bring back supported versions section as a dialog #778
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oscfdezdz
force-pushed
the
supported-versions-dialog
branch
4 times, most recently
from
f4638d1 to
0e5da1c
Compare
oscfdezdz
force-pushed
the
supported-versions-dialog
branch
from
923398c to
8e570da
Compare
Drops ExmInfoBar in favor of a GtkListBox. Now that the version row has to indicate that it opens another view with go-next-symbolic, we have the perfect excuse to move the subtitles to the row's suffix and get rid of the hacky CSS. We can revisit this in the future with a more friendly widget for horizontal layouts.
|
Holding this for now until we complete #785, which will provide more information and allow us to display it in a GtkListBox or similar. Also, the creation of the dialog is wrong, it will have to be revised. |
oscfdezdz
force-pushed
the
supported-versions-dialog
branch
from
8e570da to
4de0039
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Drops ExmInfoBar in favor of a GtkListBox. Now that the version row has to indicate that it opens another view with go-next-symbolic, we have the perfect excuse to move the subtitles to the row's suffix and get rid
of the hacky CSS.
We can revisit this in the future with a more friendly widget for horizontal layouts.
Close #659