Adaptability and UI tweaks #770
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By increasing its size and adding dim-label style to match AdwStatusPage.
By adding monospace and multiline styles and enabling subtitle-selectable property.
Also starts using property bindings for the most trivial ones.
external-link-symbolic is used without it across GNOME apps most of the times.
Instead of using setters, it enables property bindings.
oscfdezdz
force-pushed
the
various-tweaks
branch
4 times, most recently
from
6fe6409 to
34123ea
Compare
Also tweaks search-row style to mimic AdwActionRow.
Prevents an initial scroll by the previous focus.
Since GtkLabel's `single-line-mode` and `use-markup` properties do not seem to work together, this is the way to avoid displaying the line break symbol while keeping the most important part of the description in the vast majority of cases.
Improves the situation for extensions with long names on smaller form factors.
Improves the situation for extensions with long names and descriptions on smaller form factors.
We already do a search by default, doing this one results in "No results found".
ExmInstallButton now has a GtkStack as a child with a GtkImage page and a GtkLabel one. A new property, icon-only, is bound to the former. Adds an AdwBreakpoint to ExmBrowsePage to dynamically manage layout properties. The breakpoint updates ExmSearchRow's new compact property, which is bound to the icon-only property of ExmInstallButton.
Prevents constant writing to disk with any change of the window state.
In stable manifest
Now that we do not use a grid inside ExmSearchRow since commit 2dc8186, extension name and creator were read twice.
It does not work when it is set in blueprint.
oscfdezdz
force-pushed
the
various-tweaks
branch
2 times, most recently
from
fd107a5 to
99ec088
Compare
For strings not visible in screenshots, as the UI of the explanations in Weblate has led to confusion.
oscfdezdz
force-pushed
the
various-tweaks
branch
from
99ec088 to
e8e9c7e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are also other minor changes that are not enough reason to create another pull request in my opinion, see commit messages for more details.
The most notable UI improvement is: