Disable install button during installation #769
+269
−130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oscfdezdz
force-pushed
the
disable-install-button-during-installation
branch
2 times, most recently
from
9429a32 to
e3f08cf
Compare
Use shell_extensions_call_install_remote_extension/finish instead.
Introduces a new installing state that is set before activating `ext.install` action. To deal with cancellations, a new `install-status` signal is added to ExmManager which is emitted whenever it happens and reverts the button state to the last one it had, either default or unsupported. ExmSearchRow drops `is-installed` and `is-supported` properties in favor of a new `manager` property to connect to ExmManager's `install-status signal. The implementation will most likely be simplified in the future with the unified subsystem, binding the downloading state of ExmExtension to the installing state introduced here.
oscfdezdz
force-pushed
the
disable-install-button-during-installation
branch
from
e3f08cf to
cb4b9be
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From the main commit:
Fix #673