-
Notifications
You must be signed in to change notification settings - Fork 879
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update defaults to match CommonMark & Github conventions #425
base: master
Are you sure you want to change the base?
Update defaults to match CommonMark & Github conventions #425
Conversation
@pavelhoral please review! |
Are these defaults specified anywhere? |
John Gruber's spec - the first set of conventions - aren't really used as much nowadays 🤔 These GitHub conventions are all listed here, but never explained as "conventions": |
Good news 🎉 - CommonMark's Markdown reference help page clearly matches and favours these conventions |
There is a type in the commit, |
Cheers thanks for that @acnebs |
|
✅ Done @huan086 |
You should get the tests to pass. |
Tests are passing - @domchristie @martincizek |
Closes #424.
This pull introduces the CommonMark (now Github flavor, Reddit flavor) conventions that people use.
CommonMark is so popular compared to Josh Gruber's original Markdown spec that we should favor it.