-
Notifications
You must be signed in to change notification settings - Fork 15
Making add dataclass options public #60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
martinResearch
wants to merge
2
commits into
mivade:main
Choose a base branch
from
martinResearch:making_add_dataclass_options_public
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,11 +1,12 @@ | ||
import argparse | ||
import sys | ||
import unittest | ||
import datetime as dt | ||
from dataclasses import dataclass, field | ||
|
||
from typing import List, Optional, Union | ||
|
||
from argparse_dataclass import parse_args, parse_known_args | ||
from argparse_dataclass import add_dataclass_options, parse_args, parse_known_args | ||
|
||
|
||
class NegativeTestHelper: | ||
|
@@ -53,6 +54,21 @@ class Opt: | |
|
||
self.assertRaises(TypeError, parse_args, Opt, []) | ||
|
||
def test_add_dataclass_options(self): | ||
@dataclass | ||
class Opt: | ||
x: int = 42 | ||
y: bool = False | ||
argpument_parser = argparse.ArgumentParser() | ||
add_dataclass_options(Opt, argpument_parser) | ||
params = argpument_parser.parse_args([]) | ||
print(params) | ||
self.assertEqual(42, params.x) | ||
self.assertEqual(False, params.y) | ||
Comment on lines
+64
to
+67
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
|
||
params = params = argpument_parser.parse_args(["--x=10", "--y"]) | ||
self.assertEqual(10, params.x) | ||
self.assertEqual(True, params.y) | ||
|
||
def test_bool_no_default(self): | ||
@dataclass | ||
class Opt: | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to keep the default as
MISSING
so that the dataclass's initialization handles the default value. This is needed sodefault_factory
can work correctly.Also, doing it this way makes the initialization consistent with initializing the dataclass outside of the
argparse_dataclass
package