Skip to content

Conversation

KatelynGit
Copy link
Contributor

What are the relevant tickets?

https://github.mit.edu/MIT-OL-Data-Platform/Data-Platform-Issues/issues/4

Description (What does it do?)

adds platform, program_type, program_track, and program_readable_id fields to the program_summary_report

How can this be tested?

dbt build --select program_summary_report

@rachellougee rachellougee self-assigned this May 23, 2025
Copy link
Contributor

@rachellougee rachellougee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I didn't get to it last week. The dbt run successfully. However, when I check the data, the program_type, program_track and program_readable_id are all NULL for edX.org, which doesn't seem correct.

The initial design for program_summary_report was to group all the variants into one (see the original issue - To keep the summary simple, we will summarize all these variants as one program). This is why the program_track was not included in the report. @pdpinch is this requirement changed?

However, the current logic appears to be grouping by both program_readable_id, program_type and program_track, which should create separate rows for each variant. That is fine as long as the grouping is intentional, but for the program Statistics and Data Science, the summary should not be a single row now because it has 4 variants (4 program tracks). Here is the dashboard for "Statistics and Data Science" in https://bi.ol.mit.edu/superset/dashboard/p/ed9qrbjqxan/ for comparison.

@KatelynGit Can you please take a look?

@KatelynGit
Copy link
Contributor Author

Sorry, I didn't get to it last week. The dbt run successfully. However, when I check the data, the program_type, program_track and program_readable_id are all NULL for edX.org, which doesn't seem correct.

The initial design for program_summary_report was to group all the variants into one (see the original issue - To keep the summary simple, we will summarize all these variants as one program). This is why the program_track was not included in the report. @pdpinch is this requirement changed?

However, the current logic appears to be grouping by both program_readable_id, program_type and program_track, which should create separate rows for each variant. That is fine as long as the grouping is intentional, but for the program Statistics and Data Science, the summary should not be a single row now because it has 4 variants (4 program tracks). Here is the dashboard for "Statistics and Data Science" in https://bi.ol.mit.edu/superset/dashboard/p/ed9qrbjqxan/ for comparison.

@KatelynGit Can you please take a look?

Thanks for taking a look Rachel. I'll look into it. Just to give background- the reason for this request was really driven by Jeremy Rossen and others looking as SDS program data and were trying to use the filters on the left hand side of the dashboard here- https://bi.ol.mit.edu/superset/dashboard/p/vmQq1YwqAdJ/ they noticed the filters weren't working for the summary tab and needed them to answer some of their questions.

@rachellougee
Copy link
Contributor

rachellougee commented May 27, 2025

Just to give background- the reason for this request was really driven by Jeremy Rossen and others looking as SDS program data and were trying to use the filters on the left hand side of the dashboard here- https://bi.ol.mit.edu/superset/dashboard/p/vmQq1YwqAdJ/ they noticed the filters weren't working for the summary tab and needed them to answer some of their questions.

Good to know. https://github.com/mitodl/hq/issues/6124#issuecomment-2546322904 - this is where we left when Peter noticed the same thing, so I can understand the confusion - it wasn't designed to filter by program type, only by name.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants