Fix custom permissions namespace safety #181
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change resolves issue mitchspano#153 by implementing namespace-aware permission checking in both MetadataTriggerHandler and FinalizerHandler classes. Changes made: - Added checkPermissionNamespaceAware() method to handle both namespaced and non-namespaced custom permissions - Updated populatePermissionMap() to use the new namespace-aware method - Added comprehensive test coverage for the new functionality - Enhanced .gitignore to prevent Claude-related files from being committed The solution tries the permission as provided first, then falls back to trying without the namespace prefix if the original fails. This ensures compatibility across different package deployment contexts. Resolves mitchspano#153 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
MetadataTriggerHandlerandFinalizerHandler.gitignoreto prevent Claude-related files from being committedChanges Made
checkPermissionNamespaceAware()method to both handler classespopulatePermissionMap()to use the new namespace-aware methodTechnical Details
When the framework is packaged in a namespace,
FeatureManagement.checkPermission()only works for custom permissions that share the same namespace as the calling code. This fix implements a fallback mechanism that tries both the original permission name and the permission name without the namespace prefix.Test plan
Resolves #153
🤖 Generated with Claude Code