feat(iocp): prefer async connect #158
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @Corendos I'd be glad if you could review this one too 👀 |
Corendos
reviewed
May 8, 2025
| else => .{ .result = .{ .connect = windows.unexpectedWSAError(err) } }, | ||
| const as_socket = asSocket(v.socket); | ||
| // Associate our socket with loop's completion port. | ||
| self.associate_fd(v.socket) catch unreachable; |
There was a problem hiding this comment.
Suggested change
| self.associate_fd(v.socket) catch unreachable; | |
| self.associate_fd(completion.handle().?) catch unreachable; |
Don't forget to update Completion.handle as well though
Comment on lines
+554
to
+563
| // NOTE: This can be declared in somewhere else; it all happens in comptime though so no issue putting it here. | ||
| const LPFN_CONNECTEX = *const fn ( | ||
| Socket: windows.ws2_32.SOCKET, | ||
| SockAddr: *const windows.ws2_32.sockaddr, | ||
| SockLen: posix.socklen_t, | ||
| SendBuf: ?*const anyopaque, | ||
| SendBufLen: windows.DWORD, | ||
| BytesSent: *windows.DWORD, | ||
| Overlapped: *windows.OVERLAPPED, | ||
| ) callconv(.winapi) windows.BOOL; |
There was a problem hiding this comment.
This should probably be moved to src/windows.zig
| // The following is necessary for various functions (shutdown, getsockopt, setsockopt, getsockname, getpeername) to work. | ||
| // https://learn.microsoft.com/en-us/windows/win32/api/mswsock/nc-mswsock-lpfn_connectex#remarks | ||
| // https://stackoverflow.com/questions/13598530/connectex-requires-the-socket-to-be-initially-bound-but-to-what | ||
| _ = windows.ws2_32.setsockopt(asSocket(v.socket), windows.ws2_32.SOL.SOCKET, windows.ws2_32.SO.UPDATE_CONNECT_CONTEXT, null, 0); |
There was a problem hiding this comment.
Suggested change
| _ = windows.ws2_32.setsockopt(asSocket(v.socket), windows.ws2_32.SOL.SOCKET, windows.ws2_32.SO.UPDATE_CONNECT_CONTEXT, null, 0); | |
| _ = windows.ws2_32.setsockopt(as_socket, windows.ws2_32.SOL.SOCKET, windows.ws2_32.SO.UPDATE_CONNECT_CONTEXT, null, 0); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #151. API is not changed; all tests are passing as before.