Fix wishlist filter dropdown not applying filter on change#57
Merged
Conversation
The filterBy select was missing @Bind:after="HandleSearch", so changing the filter type (Collaborative Only, Private Only) had no visible effect — ApplyFiltersAndSort() was never called. This mirrors the existing pattern already used on the sortBy dropdown. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The filter dropdown on the Wishlists page (
/wishlists) had no effect when changed. Selecting "Collaborative Only" or "Private Only" did not update the displayed wishlists.Root cause: The
filterByselect element used@bind="filterBy"without a@bind:aftercallback, soApplyFiltersAndSort()was never called when the user changed the filter. The adjacent sort dropdown already uses this pattern correctly with@bind:after="HandleSort".Fix
Added
@bind:after="HandleSearch"to thefilterByselect, mirroring the existing pattern on the sort dropdown.Files changed
src/OpenWish.Web.Client/Components/Pages/Wishlists/Index.razor