Skip to content

Conversation

@mirmirmirr
Copy link
Owner

This pull request makes several documentation improvements and minor code clarifications for the Keystroke Overlay module. The most significant changes are enhancements to the user and developer documentation, including expanded explanations of supported character sets and known behaviors, as well as improved code comments for clarity.

Documentation improvements:

  • Expanded the developer documentation (keystrokeoverlay.md) to include details about supported character sets, known behaviors (such as how held keys and capital letters are processed), and future considerations for layout and positioning.
  • Removed the redundant user-facing documentation file keystrokeoverlay_microsoftlearn.md to reduce duplication and streamline documentation.

Code clarity:

  • Added descriptive comments to the try_push and try_pop methods in the SpscRing class in EventQueue.h to clarify their behavior for future maintainers. [1] [2]

dsm20 and others added 3 commits December 12, 2025 15:30
-Moved keystrokeoverlay.md to doc/devdocs/modules
-Removed Microsoft Learn file as it will be sent separately
Copilot AI review requested due to automatic review settings December 13, 2025 03:07
@mirmirmirr mirmirmirr merged commit e04c264 into module Dec 13, 2025
11 of 12 checks passed
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR improves documentation and code clarity for the Keystroke Overlay module by expanding developer documentation with technical details, removing redundant user-facing documentation, and adding helpful inline code comments.

Key changes:

  • Enhanced developer documentation with character set support details and known behavior explanations
  • Removed duplicate user-facing documentation file to streamline docs
  • Added clarifying comments to queue operations in EventQueue.h

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
keystrokeoverlay_microsoftlearn.md Removed redundant user-facing documentation file
EventQueue.h Added descriptive comments to try_push and try_pop methods explaining return behavior
keystrokeoverlay.md Enhanced with character set support details, known behaviors (key holding, capital letter handling), and future layout considerations

@github-actions
Copy link

@check-spelling-bot Report

🔴 Please review

See the 📂 files view, the 📜action log, or 📝 job summary for details.

Unrecognized words (14)
dwmwa
dwmwcp
ello
embeddedhtml
getkeyboard
JOBOBJECT
JOBOBJECTLIMIT
keystate
lgdi
Pipeserver
spsc
swp
Timestamping
xstring
These words are not needed and should be removed cabstr CIBUILD djwsxzxb DWMWA DWMWCP icf ksa Olllama rtm suntimes SWP TARGETDIR utm

Some files were automatically ignored 🙈

These sample patterns would exclude them:

^src/modules/KeystrokeOverlay/KeystrokeOverlayModuleInterface/resource\.h$

You should consider adding them to:

.github/actions/spell-check/excludes.txt

File matching is via Perl regular expressions.

To check these files, more of their words need to be in the dictionary than not. You can use patterns.txt to exclude portions, add items to the dictionary (e.g. by adding them to allow.txt), or fix typos.

To accept these unrecognized words as correct, update file exclusions, and remove the previously acknowledged and now absent words, you could run the following commands

... in a clone of the [email protected]:mirmirmirr/PowerToys.git repository
on the module-frontend-ui branch (ℹ️ how do I use this?):

curl -s -S -L 'https://raw.githubusercontent.com/check-spelling/check-spelling/c635c2f3f714eec2fcf27b643a1919b9a811ef2e/apply.pl' |
perl - 'https://github.com/mirmirmirr/PowerToys/actions/runs/20185861861/attempts/1' &&
git commit -m 'Update check-spelling metadata'

OR

To have the bot accept them for you, comment in the PR quoting the following line:
@check-spelling-bot apply updates.

Errors and Warnings ❌ (3)

See the 📂 files view, the 📜action log, or 📝 job summary for details.

❌ Errors and Warnings Count
⚠️ binary-file 1
❌ check-file-path 2
⚠️ ignored-expect-variant 1

See ❌ Event descriptions for more information.

If the flagged items are 🤯 false positives

If items relate to a ...

  • binary file (or some other file you wouldn't want to check at all).

    Please add a file path to the excludes.txt file matching the containing file.

    File paths are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your files.

    ^ refers to the file's path from the root of the repository, so ^README\.md$ would exclude README.md (on whichever branch you're using).

  • well-formed pattern.

    If you can write a pattern that would match it,
    try adding it to the patterns.txt file.

    Patterns are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your lines.

    Note that patterns can't match multiline strings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants