Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ember-qunit dependencies check #2209

Closed

Conversation

ndekeister-us
Copy link

@ndekeister-us ndekeister-us commented Jul 8, 2021

Not 100% sure if it is on ember-cli-mirage side or https://github.com/embroider-build/embroider

But in projects using ember-mocha and latest version of https://github.com/embroider-build/embroider, we enter this condition -> https://github.com/miragejs/ember-cli-mirage/blob/master/addon-test-support/index.js#L6

It leads to test suite failing because window.QUnit is undefined, so window.QUnit.config throws an error

Reproduced randomly on this repo -> ndekeister-us/Admin#1 ; commit c6dec4ba829975297d00f0c3fe438f052b1bd257 (clone it, run tests)

It seems that when using macroCondition(dependencySatisfies(...)) (as seen in https://github.com/ember-cli/ember-exam/blob/master/addon-test-support/-private/get-test-loader.js#L11 for example) it fix the issue

Tested on

  • public repo using ember-mocha
  • private repo using ember-qunit

(Should we add a new project to test-projects using ember-mocha?)


As i'm not able to reproduce it anymore, putting this PR on draft until i'm able to reproduce the issue and, by so, be sure that the fix is needed (maybe someone was wrong with my environment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant