Added connection between rules of the same ruleset#9
Open
ckosmowski wants to merge 3 commits intomiohtama:masterfrom
Open
Added connection between rules of the same ruleset#9ckosmowski wants to merge 3 commits intomiohtama:masterfrom
ckosmowski wants to merge 3 commits intomiohtama:masterfrom
Conversation
- Fixed passing parameters to evalCondition - Fixed the control parameter of the call to evalCondition (this.control did not exist).
…le rules affect a control, every rule must be true to make the control visible
Owner
|
Hi. This code looks good. Would it be possible to contribute related changes to documentation or examples, so that there would be an example how this all should work? |
|
This would be a great improvement. Is there any way to move this forward. Adding 'OR' would be great as well. |
|
This is not working well. |
Owner
|
@javierciccarelli Care to clarify? |
|
Yes, sorry, I was in a rush and I couldn't finish. The && seems to work but when I switch it to || it is not working as I should expect. If you have two rules and both of them do a .include() on the same element, it will only work for the second one, not the first one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If more then one rules in a ruleset affects the same control, the rules should be connected in some way. For now i connected them with "AND" operator so every rule affecting a control must be true to make the control visible. Otherwise it will be hidden. This allows constructing more complex rules on the same level.