Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Persist original browser name #42

Merged
merged 1 commit into from
Nov 2, 2024
Merged

Conversation

uuf6429
Copy link
Member

@uuf6429 uuf6429 commented Nov 2, 2024

Fixes browser name problems with tests on chromium/edge (and possibly other aliased browsers).

@uuf6429 uuf6429 requested a review from aik099 November 2, 2024 20:32
@uuf6429 uuf6429 marked this pull request as ready for review November 2, 2024 20:32
Copy link

codecov bot commented Nov 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.55%. Comparing base (ea2ee82) to head (efe2b13).
Report is 3 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main      #42      +/-   ##
============================================
+ Coverage     81.76%   84.55%   +2.79%     
- Complexity      191      276      +85     
============================================
  Files             1        1              
  Lines           488      764     +276     
============================================
+ Hits            399      646     +247     
- Misses           89      118      +29     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@uuf6429 uuf6429 merged commit 630842f into main Nov 2, 2024
49 of 58 checks passed
@uuf6429 uuf6429 deleted the bugfix/persist-original-browser-name branch November 2, 2024 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants