Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use chromium that run ARM and x86_64, and use dev webdriver. #29

Merged
merged 3 commits into from
Aug 6, 2024

Conversation

saidatom
Copy link
Contributor

@saidatom saidatom commented Aug 5, 2024

No description provided.

Copy link

codecov bot commented Aug 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.24%. Comparing base (73ad0b6) to head (11fcbef).

Additional details and impacted files
@@            Coverage Diff            @@
##               main      #29   +/-   ##
=========================================
  Coverage     82.24%   82.24%           
  Complexity      191      191           
=========================================
  Files             1        1           
  Lines           473      473           
=========================================
  Hits            389      389           
  Misses           84       84           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@uuf6429 uuf6429 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! I've left a few review comments..

.github/workflows/ci.yml Outdated Show resolved Hide resolved
.github/workflows/ci.yml Outdated Show resolved Hide resolved
composer.json Outdated Show resolved Hide resolved
docker-compose.yml Outdated Show resolved Hide resolved
@uuf6429 uuf6429 self-requested a review August 6, 2024 00:03
Copy link
Member

@uuf6429 uuf6429 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pretty sure the failed tests are unrelated to these changes, so the PR looks fine IMO.
I'll look at the failures separately.

@uuf6429 uuf6429 merged commit 9567c6e into minkphp:main Aug 6, 2024
26 of 30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants