Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TEST: output all current telemetry events in codebase #866

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

markreesmoj
Copy link
Contributor

@markreesmoj markreesmoj commented Feb 26, 2025

The following three events have not been output in the last six months

CprRecordHardDeleted
CprUUIDHardDeleted
CprUnmergeRecordNotFound

I would like to propose the following actions:

CprCandidateRecordSearch KEEP
CprDomainEventReceived REMOVE - replace with built in AppInsights
CprMatchCallFailed REMOVE - replace with built in AppInsights
CprMatchPersonRecordDuplicate KEEP
CprMatchScore KEEP
CprMergeEventReceived REMOVE - replace with built in AppInsights
CprMergeRecordNotFound KEEP
CprMessageProcessingFailed REMOVE - replace with built in AppInsights
CprNewRecordExists REMOVE - unnecessary
CprReclusterClusterRecordsNotLinked KEEP
CprReclusterMatchFoundMergeRecluster KEEP
CprReclusterMessageReceived REMOVE - replace with built in AppInsights
CprReclusterNoChange KEEP
CprReclusterNoMatchFound KEEP
CprRecordCreated KEEP
CprRecordHardDeleted REMOVE - never happens
CprRecordMerged KEEP
CprRecordUnmerged KEEP
CprRecordUpdated KEEP
CprSplinkCandidateRecordsFoundGetUUID 
CprUUIDHardDeleted REMOVE - never happens
CprUnmergeEventReceived REMOVE - replace with built in AppInsights
CprUnmergeLinkNotFound KEEP
CprUnmergeRecordNotFound REMOVE - never happens
CprUpdateRecordDoesNotExist REMOVE - unnecessary
CprUuidCreated KEEP
CprUuidReclusterNeedsAttention KEEP

This will save a good number of tests and attendant code complexity - which will speed up development and test runs.
We will have to change some of the dashboard queries along these lines

BEFORE
AppEvents
| where AppRoleName == "hmpps-person-record"
| where Name =="CprMatchCallFailed"

AFTER
AppDependencies
| where Success == false
| where AppRoleName == "hmpps-person-record"
| where DependencyType == "HTTP"
| where Target == "hmpps-person-match-score.hmpps.service.justice.gov.uk"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant