CPR-458 Add Recluster event log #729
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
H-Iwanejko
changed the title
H-Iwanejko
changed the title
markreesmoj
reviewed
Dec 10, 2024
|
|
||
| withType<JavaCompile>().configureEach { | ||
| options.isFork = true | ||
| } |
There was a problem hiding this comment.
markreesmoj
reviewed
Dec 10, 2024
| @@ -1,5 +1,7 @@ | |||
| package uk.gov.justice.digital.hmpps.personrecord.jpa.entity | |||
|
|
|||
| import com.fasterxml.jackson.annotation.JsonBackReference | |||
| import com.fasterxml.jackson.annotation.JsonIgnore | |||
markreesmoj
reviewed
Dec 10, 2024
| @@ -7,5 +7,8 @@ import uk.gov.justice.digital.hmpps.personrecord.jpa.entity.EventLoggingEntity | |||
| @Repository | |||
| interface EventLoggingRepository : JpaRepository<EventLoggingEntity, Long> { | |||
| fun findFirstBySourceSystemIdOrderByEventTimestampDesc(sourceSystemId: String): EventLoggingEntity? | |||
|
|
|||
| fun findFirstByUuidOrderByEventTimestampDesc(uuid: String): EventLoggingEntity? | |||
|
|
|||
markreesmoj
reviewed
Dec 10, 2024
| @@ -35,24 +34,13 @@ data class Person( | |||
| val contacts: List<Contact> = emptyList(), | |||
| val addresses: List<Address> = emptyList(), | |||
| val references: List<Reference> = emptyList(), | |||
| var selfMatchScore: Double? = null, | |||
markreesmoj
reviewed
Dec 10, 2024
| @@ -187,31 +178,6 @@ data class Person( | |||
| currentlyManaged = prisoner.currentlyManaged, | |||
| ) | |||
| } | |||
|
|
|||
| fun from(existingPersonEntity: PersonEntity): Person { | |||
markreesmoj
reviewed
Dec 10, 2024
| val sourceSystemType: SourceSystemType, | ||
| val sentences: List<SentenceInfo> = emptyList(), | ||
| val currentlyManaged: Boolean? = null, | ||
| ) { | ||
|
|
||
| companion object { | ||
|
|
||
| fun Person?.extractSourceSystemId(): String? { |
markreesmoj
reviewed
Dec 10, 2024
| @@ -16,25 +20,50 @@ class EventLoggingService( | |||
| private val objectMapper: ObjectMapper, | |||
| ) { | |||
|
|
|||
| fun snapshotPersonEntity(personEntity: PersonEntity) = snapshotEntity<PersonEntity>(personEntity) | |||
|
|
|||
| fun snapshotPersonKeyEntity(personKeyEntity: PersonKeyEntity) = snapshotEntity<PersonKeyEntity>(personKeyEntity) | |||
There was a problem hiding this comment.
interesting, possibly could be used more widely
markreesmoj
reviewed
Dec 10, 2024
| processedPerson: Person?, | ||
| uuid: String? = null, | ||
| beforePersonEntity: PersonEntity?, | ||
| afterPersonEntity: PersonEntity?, |
There was a problem hiding this comment.
I tried this and found that they were often one and the same - maybe things have moved on since then
There was a problem hiding this comment.
This naming is definitely better
markreesmoj
reviewed
Dec 10, 2024
|
|
||
| fun recordEventLog( |
markreesmoj
reviewed
Dec 10, 2024
| return personEntity | ||
| } | ||
|
|
||
| private fun handlePersonUpdate(person: Person, existingPersonEntity: PersonEntity, event: String?): PersonEntity { | ||
| val beforePersonEntity = eventLoggingService.snapshotPersonEntity(existingPersonEntity) |
There was a problem hiding this comment.
As far as I can see, this method call is compulsory now before calling recordEventLog? Otherwise you run the (considerable) risk of just sending in the entity, which is probably managed and therefore the before and after will be the same.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.