Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Man 82 activity log #289

Merged
merged 28 commits into from
Jan 29, 2025
Merged

Man 82 activity log #289

merged 28 commits into from
Jan 29, 2025

Conversation

neil-mills
Copy link
Contributor

No description provided.

@neil-mills
MAN-82 activity log filter menu ui wip
47b8e94
@neil-mills
MAN-82 working draft of filter menu functionality
4f7feb1
@neil-mills
MAN-82 filter menu date range validation wip
4a8a2f3
@neil-mills
MAN-167 add invalid date format regex validation
f3c0b71
@neil-mills
MAN-167 redirect url if validation passes
ab47ca1
@neil-mills
MAN-82 improve type definitions of res.locals vars
8fc4d13
@neil-mills
MAN-82 activity log filter menu wip
7b2401b
@neil-mills
MAN-82 various bug fixes, working pagination
17c4987
@neil-mills
MAN-82 add no results state
d44b1fe
@neil-mills
MAN-82 add caching for activity log request
fa6f58e
@neil-mills
MAN-82 update ui for activity log result cards
1dbb173
@neil-mills
MAN-226 Add record and outcome filter
1e25b47
@neil-mills
MAN-82 fix bug in results caching
28df42b
@neil-mills
MAN-226 rename request body property from 'compliance' to 'filters'
297b37b
@neil-mills
MAN-167 refactor date range validation
2230587
@neil-mills
MAN-82 add filter menu integration tests wip
da4cd78
@neil-mills
MAN-82 filter menu integration tests + bug fixes
48b1666
@neil-mills neil-mills requested a review from a team as a code owner January 27, 2025 19:33
pmcphee77
pmcphee77 previously approved these changes Jan 28, 2025
View reviewed changes
Copy link
Contributor

@pmcphee77 pmcphee77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is still some sonar smells in this? But if you want to pick this up separately?

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
5.6% Duplication on New Code

See analysis details on SonarQube Cloud

@neil-mills neil-mills merged commit 82c0d59 into main Jan 29, 2025
14 checks passed
@neil-mills neil-mills deleted the MAN-82-activity-log branch January 29, 2025 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pmcphee77 pmcphee77 pmcphee77 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@neil-mills @pmcphee77