Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAN-19: Optimize Playwright Tests to Reduce Redundancy in Delius Verification and Add Tests for Personal Details Match in MAS and Delius #153

Merged
merged 7 commits into from
Sep 23, 2024

Conversation

smalepati99
Copy link
Contributor

This PR introduces significant improvements to the Playwright tests for Delius and the Manage a Supervision (MaS) system by implementing the following changes:

  • Introduced a test.describe block to group related tests for better organization and readability.
  • Added beforeAll to set up the necessary context and preconditions for the tests, ensuring efficient test execution.
  • New Functions Added by implemented addAddress, getTypeColumnValue, addPersonalDetails, loginDeliusAndCreateOffender, createPersonalContact, retryOnError, and formatDate for enhanced modularity and reusability.
  • Included MaS-related functions - loginMasAndGoToPersonalDetails and searchForCrn, and updated assertAddressDetails for better address validation.
  • Optimized Existing Tests by enhancing the Verify the header details test to ensure accurate assertions while maintaining clarity.
  • Added a new test to verify that the personal details of a person in MAS match those in Delius, verifying data consistency across systems.
  • Ensured all tests conform to Playwright best practices, improving maintainability and reliability.

This optimization aims to enhance test performance, reduce redundancy, and improve the overall test approach

…fication and Add Tests for Personal Details Match in MAS and Delius
@smalepati99 smalepati99 requested a review from a team as a code owner September 23, 2024 07:17
e2e_tests/.env.example Outdated Show resolved Hide resolved
playwright.config.ts Outdated Show resolved Hide resolved
Copy link

@smalepati99 smalepati99 merged commit 48821ed into main Sep 23, 2024
7 checks passed
@smalepati99 smalepati99 deleted the MAN-19 branch September 23, 2024 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants