MAN-218 add new section card to personal details

ministryofjustice · Jan 24, 2025 · b55f31d · b55f31d
1 parent f0310cd
commit b55f31d
Show file tree

Hide file tree

Showing 3 changed files with 33 additions and 9 deletions.
diff --git a/integration_tests/e2e/personalDetails.cy.ts b/integration_tests/e2e/personalDetails.cy.ts
@@ -39,9 +39,12 @@ context('Personal Details', () => {
     page
       .getRowData('personalDetails', 'criminogenicNeeds', 'Value')
       .should('contain.text', 'Education, Training and Employability')
-    page.getRowData('personalDetails', 'crn', 'Value').should('contain.text', 'X000001')
     page.getRowData('personalDetails', 'documents', 'Value').should('contain.text', 'Eula-Schmeler-X000001-UPW.pdf')
 
+    page.getRowData('identityNumber', 'crn', 'Value').should('contain.text', 'X000001')
+    page.getRowData('identityNumber', 'pnc', 'Value').should('contain.text', '1954/0018147W')
+    page.getRowData('identityNumber', 'noms', 'Value').should('contain.text', 'G9566GQ')
+
     page.getRowData('equalityMonitoring', 'religionOrBelief', 'Value').should('contain.text', 'Scientology')
     page.getRowData('equalityMonitoring', 'sex', 'Value').should('contain.text', 'Female')
     page.getRowData('equalityMonitoring', 'genderIdentity', 'Value').should('contain.text', 'Non-Binary')

diff --git a/server/views/pages/personal-details.njk b/server/views/pages/personal-details.njk
@@ -320,14 +320,6 @@
                 key: { html: '<span data-qa="criminogenicNeedsLabel">Criminogenic needs</span>' },
                 value: { html: '<span data-qa="criminogenicNeedsValue">' + criminogenicNeeds + '</span>' }
               },
-              {
-                key: { html: '<span data-qa="pncLabel">PNC</span>' },
-                value: { html: '<span data-qa="pncValue" class="app-!-font-family-tabular">' + personalDetails.pnc  + '</span>' }
-              } if personalDetails.pnc,
-              {
-                key: { html: '<span data-qa="crnLabel">CRN</span>' },
-                value: { html: '<span data-qa="crnValue" class="app-!-font-family-tabular">' + personalDetails.crn + '</span>' }
-              },
               {
                 key: { html: '<span data-qa="documentsLabel">Personal documents</span>' },
                 value: { html: '<span data-qa="documentsValue">' + documents + '</span>' }
@@ -344,6 +336,33 @@
         actions: {}
     }) }}
 
+    {% set identityNumbers %}
+        {{ govukSummaryList({
+            rows: [
+                {
+                    key: { html: '<span data-qa="crnLabel">CRN</span>' },
+                    value: { html: '<span data-qa="crnValue" class="app-!-font-family-tabular">' + personalDetails.crn + '</span>' }
+                },
+                {
+                    key: { html: '<span data-qa="pncLabel">PNC number</span>' },
+                    value: { html: '<span data-qa="pncValue" class="app-!-font-family-tabular">' + personalDetails.pnc  + '</span>' }
+                } if personalDetails.pnc,
+                {
+                    key: { html: '<span data-qa="nomsLabel">Prison number</span>' },
+                    value: { html: '<span data-qa="nomsValue" class="app-!-font-family-tabular">' + personalDetails.noms  + '</span>' }
+                } if personalDetails.noms
+            ]
+        }) }}
+    {% endset %}
+
+    {{ appSummaryCard({
+        attributes: {'data-qa': 'identityNumberCard'},
+        titleText: "Identity numbers",
+        classes: 'govuk-!-margin-bottom-6 app-summary-card--large-title',
+        html: identityNumbers,
+        actions: {}
+    }) }}
+
     {% set equality %}
       {{ govukSummaryList({
         rows: [

diff --git a/wiremock/mappings/X000001-full.json b/wiremock/mappings/X000001-full.json
@@ -213,6 +213,8 @@
         "status": 200,
         "jsonBody": {
           "crn": "X000001",
+          "pnc": "1954/0018147W",
+          "noms": "G9566GQ",
           "name": {
             "forename": "Eula",
             "middleName": "",