MAN-82 fix further sonar code exception issue

ministryofjustice · Jan 29, 2025 · 4a0884c · 4a0884c
1 parent b9d0841
commit 4a0884c
Showing 1 changed file with 8 additions and 1 deletion.
diff --git a/server/middleware/validation/activityLog.ts b/server/middleware/validation/activityLog.ts
@@ -42,6 +42,13 @@ const activityLog: Route<void> = (req, res, next) => {
     }
   }
 
+  const isEmpty = (nameProp: string, dateVal: string): void => {
+    const text = properties.errorMessages['activity-log'][nameProp].errors.isEmpty
+    const name = toCamelCase(nameProp)
+    errors = utils.addError(errors, { text, anchor: name })
+    isValid[name] = false
+  }
+
   const isDateInFuture = (nameProp: string, dateVal: string): void => {
     const dateFromIso = getIsoDate(dateVal)
     const today = DateTime.now()
@@ -85,7 +92,7 @@ const activityLog: Route<void> = (req, res, next) => {
       errors = utils.addError(errors, { text, anchor: 'dateTo' })
       isValid.dateTo = false
     }
-    if (dateFrom && isValid.dateFrom && dateIsValid('dateTo')) {
+    if (dateIsValid('dateFrom') && dateIsValid('dateTo')) {
       const dateFromIso = getIsoDate(dateFrom)
       const dateToIso = getIsoDate(dateTo)
       if (dateFromIso > dateToIso) {