MAN-172: Update contact details

ministryofjustice · Feb 4, 2025 · 0a9bf27 · 0a9bf27
1 parent cf127c8
commit 0a9bf27
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/server/routes/personalDetails.ts b/server/routes/personalDetails.ts
@@ -7,7 +7,7 @@ import MasApiClient from '../data/masApiClient'
 import ArnsApiClient from '../data/arnsApiClient'
 import TierApiClient from '../data/tierApiClient'
 import type { Route } from '../@types'
-import { toIsoDateFromPicker, toPredictors, toRoshWidget, toTimeline } from '../utils/utils'
+import { toIsoDateFromPicker, toPredictors, toRoshWidget } from '../utils/utils'
 import { PersonalDetailsUpdateRequest } from '../data/model/personalDetails'
 import { validateWithSpec } from '../utils/validationUtils'
 import { personDetailsValidation } from '../properties'

diff --git a/server/utils/validationUtils.ts b/server/utils/validationUtils.ts
@@ -22,7 +22,7 @@ export interface ValidationSpec {
 }
 
 export const isEmail = (string: string) =>
-  /^(([^<>()[\]\\.,;:\s@"]+(\.[^<>()[\]\\.,;:\s@"]+)*)|(".+"))@((\[[0-9]{1,3}\.[0-9]{1,3}\.[0-9]{1,3}\.[0-9]{1,3}])|(([a-zA-Z\-0-9]+\.)+[a-zA-Z]{2,}))$/.test(
+  /^(([^<>()[\]\\.,;:\s@"]+(\.[^<>()[\]\\.,;:\s@"]+)*)|(".+"))@((\[\d{1,3}\.\d{1,3}\.\d{1,3}\.\d{1,3}])|(([a-zA-Z\-0-9]+\.)+[a-zA-Z]{2,}))$/.test(
     string,
   )
 export const isNotEmpty = (args: any[]) => {
@@ -33,7 +33,7 @@ export const isUkPostcode = (args: any[]) => {
   return postcodeValidator(args[0], 'GB')
 }
 export const charsOrLess = (args: any[]) => {
-  return !(args[1].length > args[0])
+  return args[1].length <= args[0]
 }
 export const isValidDate = (args: any[]) => {
   return !!args[0] && DateTime.fromFormat(args[0], 'd/M/yyyy').isValid