MAP-1942 redis 8 upgrade and esLint upgrade as per TEMPLATE TYPESCRIPT #220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…T Update dependencies 2024-12-05 #492
marcusaleman
commented
Dec 12, 2024
| @@ -7,7 +7,7 @@ export default class ManageUsersService { | |||
| if (username) { | |||
| try { | |||
| return await this.manageUsersApiClient.users.get(token, { username }) | |||
| } catch (e) { | |||
| } catch { | |||
There was a problem hiding this comment.
As upgraded Lint claim about unused 'e' variable
There was a problem hiding this comment.
what about logging the exception instead?
marcusaleman
commented
Dec 12, 2024
| @@ -1,6 +1,6 @@ | |||
| import { v4 as uuidv4 } from 'uuid' | |||
| import session, { MemoryStore, Store } from 'express-session' | |||
| import RedisStore from 'connect-redis' | |||
| import { RedisStore } from 'connect-redis' | |||
There was a problem hiding this comment.
marcusaleman
commented
Dec 12, 2024
| }), | ||
| ) | ||
| }) | ||
| }) | ||
|
|
There was a problem hiding this comment.
Thource
approved these changes
Dec 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a warden of hmpps-locations-inside-prison we need to update Typescript code to align to the last dependencies update and modernise code with Redis 8.
Reference Template Typescript ministryofjustice/hmpps-template-typescript#492
Code has been tested locally.