MAP-1729 - Update the service from the template project #207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Paul Solecki <[email protected]>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Paul Solecki <[email protected]>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Paul Solecki <[email protected]>
* Added ESBuild for bundling and building app
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
jimbali
reviewed
Nov 7, 2024
| ' </label>' + | ||
| '</div>' | ||
| ) | ||
| } |
There was a problem hiding this comment.
I had to add this monkey patch to get it to clear the select all checkbox, but I wasn't able to write an integration test that properly tests it. Let me check if it still works...
jimbali
approved these changes
Nov 7, 2024
| COPY --from=build --chown=appuser:appgroup \ | ||
| /app/dist ./dist | ||
|
|
||
| COPY --from=build --chown=appuser:appgroup \ | ||
| /app/node_modules ./node_modules | ||
|
|
||
| EXPOSE 3000 3001 | ||
| EXPOSE 3000 | ||
| ENV NODE_ENV='production' |
There was a problem hiding this comment.
@Thource this var is duplicated
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR brings the project up to date with hmpps-template-typescript, see https://dsdmoj.atlassian.net/browse/MAP-1729