Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub actions #60

Merged
merged 6 commits into from
Jan 27, 2025
Merged

GitHub actions #60

merged 6 commits into from
Jan 27, 2025

Conversation

alexw-moj
Copy link
Contributor

Initial investigation into using GitHub Actions

Copy link
Contributor

@pipwilson pipwilson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally I think this looks fine, but obviously it's a different approach to the one we use in circle where everything is running inside a docker container that we specify, rather than inheriting ubuntu-latest from e.g. https://github.com/ministryofjustice/hmpps-github-actions/blob/main/.github/workflows/node_unit_tests.yml. Do the changes here suggest any changes we should be making in either our local configs or Dockerfile?

Also I wonder if for the deployment jobs we should be specifying Environments (https://docs.github.com/en/actions/managing-workflow-runs-and-deployments/managing-deployments/managing-environments-for-deployment) so that we can get better traceability.

I'm not quite sure of the scope of what you're looking at right now, so hope that is useful.

Copy link
Contributor

@pipwilson pipwilson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alexw-moj alexw-moj merged commit 3f98779 into main Jan 27, 2025
12 checks passed
@alexw-moj alexw-moj deleted the github-actions branch January 27, 2025 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants