CVSL-2107 Tidying up vary approval caseload #1058
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewrlee
force-pushed
the
alee/CVSL-2107
branch
from
2677113 to
f6e3b15
Compare
andrewrlee
commented
Aug 30, 2024
| const comUsernames = caseload | ||
| .map( | ||
| offender => | ||
| offender.licences.find(l => offender.licences.length === 1 || l.status !== LicenceStatus.ACTIVE).comUsername |
There was a problem hiding this comment.
The queries are always limited to return VARIATION_SUBMITTED so no need to check status.
There should only ever be one of these per noms id so I've created an assertion that ensures there's no duplicates. (Checked prod and this is the case)
gurps-singh
approved these changes
Aug 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.