Add support for SQLite #3051
Draft
Add support for SQLite #3051
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
How do you test that? I tried this: go build -tags=sqlite -o miniflux-sqlite
export DATABASE_URL="file:/tmp/test.db"
./miniflux-sqlite -debug -migrate
level=INFO msg="Running database migrations" current_version=0 latest_version=99 driver=sqlite3
[Migration v1] near "(": syntax error |
|
Yeah, it's not a complete port. I have a bunch of other (horrible) local hacks to make this work, but I thought I would send small PR as I move forward, instead of a big one, but oh well, let's go with a big one instead! |
jvoisin
force-pushed
the
sqlite_portability
branch
7 times, most recently
from
92be012 to
c00ff89
Compare
jvoisin
force-pushed
the
sqlite_portability
branch
from
c00ff89 to
e1b50df
Compare
Miniflux can now be compiled with SQLite support. The next step are to actually make it work. - `CREATE TYPE … AS ENUM(…)` is PostgreSQL-specific, and is roughly equivalent to `CHECK(… in (…))` - Specifying the index type is PostgreSQL-specific, so let's do it conditionally based on the used driver - Replace `timestamp` with time` with `timestamptz` - Don't use full-text search for sqlite for now - `md5` isn't supported - SQLite doesn't enforce types (yes.), so no need to alter tables to change them - Various portability improvements
jvoisin
force-pushed
the
sqlite_portability
branch
from
e1b50df to
610bfb0
Compare
Open
|
Can I help with something? I think it really would be nice if Miniflux had sqlite support. |
|
Unfortunately, my free time significantly shrunk recently, as I got a new job. I'll likely return to it at some point, when things settle a bit. Feel free to build on top of this pull-request if you want, I'm happy to help review it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This MR adds support for SQLite.
It should close #1925