fix: make delete a soft delete with a revoke action - #5
Merged
Conversation
Deleting a row previously removed it permanently. Delete now shows a
"deleted" badge and dims the row instead of removing it, and a Revoke
button appears in its place, backed by the new
POST /api/admin/evaluations/{id}/revoke and
POST /api/admin/submissions/{id}/revoke endpoints (companion PR in
minirouter). deleteEvaluation/deleteSubmission now return the updated
resource instead of void, so the row updates in place rather than
disappearing from the table.
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
POST /api/admin/evaluations/{id}/revokeandPOST /api/admin/submissions/{id}/revokebackend endpoints (companion PR: fix: make evaluation/submission delete a soft delete with revoke minirouter#243).deleteEvaluation/deleteSubmissioninlib/api.tsnow return the updated resource (backend returns 200 + the resource instead of 204) so rows update in place instead of vanishing from local state.Test plan
npm run buildpassesnpm run lintpasses