feat: add delete buttons to provider tests and standings tables - #4
Merged
Conversation
Adds a Delete action to each row of the "Single provider benchmark
tests" and "Current standings" tables, backed by new
DELETE /api/admin/evaluations/{id} and DELETE /api/admin/submissions/{id}
endpoints. Confirms via window.confirm, shows a per-row spinner while
in flight, and removes the row from local state on success (with the
usual 401 -> expireSession handling).
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
deleteEvaluation/deleteSubmissionAPI client functions inadmin/src/lib/api.ts, calling the newDELETE /api/admin/evaluations/{id}andDELETE /api/admin/submissions/{id}backend endpoints (companion PR inminirouter, feat: add DELETE endpoints for evaluations/submissions + fix schema-lock contention minirouter#242).button-dangerCSS utility anddangerButtonvariant, following existing styling conventions (no prior destructive-button pattern existed in this repo).expireSession()flow like every other mutating call here.Test plan
npm run build(tsc + vite build) passesnpm run lint(oxlint) passes