Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Give mods access to imgui context #109

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

GameParrot
Copy link
Contributor

Allows mods to use imgui directly with ImGui::SetCurrentContext

Copy link
Member

@ChristopherHX ChristopherHX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Although this might read as a nice idea...

This is very very very very dangerous see git blame https://github.com/ocornut/imgui/blame/6982ce43f5b143c5dce5fab0ce07dd4867b705ae/imgui_internal.h#L2031-L2395C2

this struct is part of imgui internals and changes over time.

The whole struct layout get new items in the middle that moves other members in memory.

Doing this would stop updates of imgui in this launcher and for mods (this involves to remove the submodule updates for imgui), otherwise an unmaintainable change

Every mod must use a binary compatible snapshot of imgui, once the launcher bumps it mods are going to crash the process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants