-
Notifications
You must be signed in to change notification settings - Fork 89
Update example Emu3 performance in mindspore 2.6.0 and 2.7.0 #1417
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @chenyingshu, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on modernizing the Emu3 example to align with recent MindSpore versions (2.6.0 and 2.7.0). It involves adapting the codebase to API changes, particularly for the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates the Emu3 example with performance benchmarks for mindspore 2.6.0 and 2.7.0. A key change is the replacement of nn.BatchNorm3d with mint.nn.BatchNorm3d across the project, which is a good improvement for performance and code simplification, as it allows for the removal of the weight conversion script. The changes are applied consistently. I have one minor suggestion to improve the formatting in the README file for better consistency and readability.
…re-lab#1417) * use mint.nn.BatchNorm3d; update inference perf for ms2.6.0&ms2.7.0 * update training perf for ms2.7.0
What does this PR do?
Fixes # (issue)
mint.nn.BatchNorm3dinstead ofnn.BatchNorm3d.examples/emu3/README.mdwith ms2.6.0 and ms2.7.0 performance.Before submitting
What's New. Here are thedocumentation guidelines