Skip to content

Conversation

@chenyingshu
Copy link
Collaborator

What does this PR do?

Fixes # (issue)

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline?
  • Did you make sure to update the documentation with your changes? E.g. record bug fixes or new features in What's New. Here are the
    documentation guidelines
  • Did you build and run the code without any errors?
  • Did you report the running environment (NPU type/MS version) and performance in the doc? (better record it for data loading, model inference, or training tasks)
  • Did you write any new necessary tests?

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @chenyingshu, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on modernizing the Emu3 example to align with recent MindSpore versions (2.6.0 and 2.7.0). It involves adapting the codebase to API changes, particularly for the BatchNorm3d module, and updating the documentation with fresh performance benchmarks. The changes aim to streamline the development process by removing obsolete conversion steps and providing up-to-date information for users.

Highlights

  • MindSpore Version Compatibility: The Emu3 example has been updated to ensure compatibility with MindSpore versions 2.6.0 and 2.7.0, including necessary adjustments for the BatchNorm3d module's new location.
  • Performance Benchmarks Updated: The README.md now features comprehensive performance tables for Emu3 models (Image VQA, Text-to-Image Generation, and Training) on MindSpore 2.6.0 and 2.7.0, providing current metrics for various tasks and modes.
  • Code Simplification: The convert_weights.py script and its associated documentation have been removed, as the manual weight conversion for BatchNorm3d is no longer required due to MindSpore's API changes.
  • Training Epoch Adjustments: The number of training epochs for Text-to-Image and VQA tasks in their respective shell scripts has been reduced.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the Emu3 example with performance benchmarks for mindspore 2.6.0 and 2.7.0. A key change is the replacement of nn.BatchNorm3d with mint.nn.BatchNorm3d across the project, which is a good improvement for performance and code simplification, as it allows for the removal of the weight conversion script. The changes are applied consistently. I have one minor suggestion to improve the formatting in the README file for better consistency and readability.

@CaitinZhao CaitinZhao added this pull request to the merge queue Nov 20, 2025
Merged via the queue into mindspore-lab:master with commit 4db5550 Nov 20, 2025
3 checks passed
zackcxb pushed a commit to zackcxb/mindone that referenced this pull request Nov 21, 2025
…re-lab#1417)

* use mint.nn.BatchNorm3d; update inference perf for ms2.6.0&ms2.7.0

* update training perf for ms2.7.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants