-
Notifications
You must be signed in to change notification settings - Fork 89
feat(transformers): add Kyutai Speech-To-Text (v4.54.1) #1407
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Summary of ChangesHello @alien-0119, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly enhances the Mimi model by introducing robust streaming capabilities for its convolutional encoder, allowing for more efficient processing of continuous audio. It achieves this through a new padding cache mechanism, alongside a general cleanup and simplification of attention and initialization logic, ensuring better alignment with MindSpore's current API and improved model performance for real-time applications. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces streaming support for the Mimi speech-to-text model by adding a padding cache for convolutions. The changes also include several refactorings and updates to align with newer conventions in the library. While the implementation for streaming is mostly on the right track, I've identified a couple of critical issues where methods are removed but still called, which will cause runtime errors. There's also a minor issue of dead code that can be cleaned up.
5ea5b5e to
8c034cf
Compare
2ffcc83 to
ebf6f2f
Compare
ef78cd9 to
6349efa
Compare
What does this PR do?
Adds # (feature)
Add Kyutai Speech-To-Text model and fast ut.
Usage Example:
Performance:
Experiments were tested on Ascend Atlas 800T A2 machines with mindspore 2.7.0 pynative mode.
Before submitting
What's New. Here are thedocumentation guidelines
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.
@xxx